This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Added option layout.hierarchical.userControlsFreeAxis (revision 2)#4183
Open
softwareCobbler wants to merge 5 commits intovisjs:developfrom
softwareCobbler:userControlsFreeAxis
Open
Added option layout.hierarchical.userControlsFreeAxis (revision 2)#4183softwareCobbler wants to merge 5 commits intovisjs:developfrom softwareCobbler:userControlsFreeAxis
softwareCobbler wants to merge 5 commits intovisjs:developfrom
softwareCobbler:userControlsFreeAxis
Conversation
Author
|
in lieu of an example: Video of what it does |
softwareCobbler
changed the title
softwareCobbler
commented
Jan 22, 2019
lib/network/Network.js
Outdated
| console.log(this.layoutEngine); | ||
| // | ||
| // this clears "userControlsFreeAxis" when "hierarchical" is disabled | ||
| // without doing this, and performing the following steps: |
Author
There was a problem hiding this comment.
May still be a good idea to clear the userControlsFreeAxis option if hierarchical layout is disabled, but the bug I was attempting to fix is probably #4228.
Open
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit solves a question I asked on stackoverflow: https://stackoverflow.com/questions/53127971/how-can-i-set-node-positions-in-a-hierarchical-layout
Here we override the
LayoutEnginelogic if a user has BOTH specified this option and supplied a "free axis" value in any of their nodes within theDatasetthey've bound toNetwork. The "free axis" isxifhierarchical.directionis"DU"/"UD", andyif it's"LR"/"RL". Undefined values for the free axis leaveLayoutEnginedoing what it did prior to this commit.In addition I added some documentation for this in './docs/network/layout.html'.